commit | 35a8f0de5a522de005b33c48f7937f56f88f753b | [log] [tgz] |
---|---|---|
author | Ross McIlroy <rmcilroy@chromium.org> | Thu Sep 06 20:22:41 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 06 20:22:41 2018 |
tree | 672324b15b1f77585cb083a4882f5baba09a2461 | |
parent | a7a26d22d49a44ade6bef4702c453623bb199fce [diff] |
Revert "[v8] Re-post non-blocking ScriptStreamer tasks (reland)" This reverts commit 04bab18044ca5689ac72a05883051d23b9f354df. Reason for revert: Failing DCHECKs by blocking on non-blocking task. BUG:878750 Original change's description: > [v8] Re-post non-blocking ScriptStreamer tasks (reland) > > Posted blocking ScriptStreamer tasks can end up in a queue, and have > their Resource complete loading before the task even starts. When this > happens, these tasks will no longer block on network input, but they > will still be posted to the blocking task runner, which does not spin up > new threads if the running task is not blocked. When there are a lot of > small functions posted for streaming, this results in a slightly > paradoxical starvation, where the blocking task runner is processing > lots of no-longer-blocking tasks all in one thread, as it has no reason > to spin up new threads. > > To avoid this, if a streaming task isn't started before the resource > finishes loading, we can cancel this posted task, and instead post a new > non-blocking task to the non-blocking thread pool. This frees up the > blocking task runner to process only blocking tasks (and thus allows it > to spin up new threads for them). > > TBR=kouhei@chromium.org > > Bug: chromium:865098 > Bug: chromium:866868 > Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb > Reviewed-on: https://chromium-review.googlesource.com/1179744 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584032} TBR=rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:865098, chromium:866868 Change-Id: I8c26832b131cf8997c304422eb0324bb0770b947 Reviewed-on: https://chromium-review.googlesource.com/1211582 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589272}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .