| commit | be041f3e7506d634d80f9bdb4323b118efd59554 | [log] [tgz] |
|---|---|---|
| author | gogerald <gogerald@chromium.org> | Wed Dec 09 22:50:25 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Dec 09 22:52:11 2015 |
| tree | 8cf7892fdc01540691360bedf38adfe7d30b9f13 | |
| parent | 5cacf70cc85a4c73d001845c9d50be56e8799c5e [diff] |
Do not reuse webcontent which associates constrained login page. Previously if the login page was opened in avatar bubble the source will always be SOURCE_AVATAR_BUBBLE_SIGN_IN even though it was triggered in settings, so sync settings confirmation view was shown, which is a bug. After landing https://codereview.chromium.org/1473543002/ the access point (source) is correct (ACCESS_POINT_SETTINGS), but triggerd this problem when the login page is opened in avatar bubble (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/options/sync_setup_handler.cc&l=384). BUG=567794 Review URL: https://codereview.chromium.org/1511023002 Cr-Commit-Position: refs/heads/master@{#364188}