commit | 36f5bb5e7c843d8768b86977fc879135da365eea | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Fri Aug 31 08:09:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Aug 31 08:09:27 2018 |
tree | 23bb3974bdf5d693a4036c42686cf2b70e111a29 | |
parent | 3b06b81f4b9d5eafc7f65821522bc19bc362a93f [diff] |
Update LayoutTest /history/redirect-js-* (11 tests) The current behavior of chrome is the following one: --- When a javascript navigation is triggered, if it happens: * before the load event, replace the current history entry. * after the load event, append a new history entry. --- The first case is sometimes called "javascript-redirect". The current set of tests uses two kind of tests. One with a timeout of 2 seconds. This one is expected to happens after the load event. Another one with a timeout of 0 seconds. We don't really know this one is expected to happens. This is flaky. It usually happens after the load event, but it is non deterministic. This CLs removes: * /http/tests/history/redirect-js-*-0-seconds}.html * /http/tests/history/redirect-js-*-2-seconds}.html And completes: * /http/tests/history/redirect-js-*-before-load}.html * /http/tests/history/redirect-js-*-after-load}.html It modifies the tests so that they really depend on the load event, not on timing, which is not reliable. Bug: 862591, 831155 Change-Id: I3d568019c8616e6b52b9db554ad95ed312bd82d9 Reviewed-on: https://chromium-review.googlesource.com/1185094 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#587965}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .