commit | 377d251f10614cc178f7d56d7425d62107972def | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Mon Oct 14 18:01:39 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 14 18:01:39 2019 |
tree | a86e158ccf2ec1fe6e9a16ebcea69a08b0ac5444 | |
parent | 0ca844e294d930184ce4859fff5d558b0e754c44 [diff] |
Make download_from_google_storage_unittest.py work with Python 3. Make sure we use bytes and strings in the appropriate places: * Call decode() when reading data from a file since we are then treating the data as a string. * Make the GsutilsMock expectations use bytes rather than strings, as the non-mock version ultimately calls subprocess.Popen.communicate() in a mode that returns bytes, not strings. Bug: 984182, 1007872 Change-Id: I7e03e404889d66f0f7cb77bbdbbfa9f7c5721657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1859997 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.