commit | 37f67ef488ec98c04f8d2a4c5d5ae78e317b8fca | [log] [tgz] |
---|---|---|
author | Zhiqiang Zhang <zqzhang@chromium.org> | Tue Dec 04 02:37:33 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 04 02:37:33 2018 |
tree | 1082b34068f3aa1fb1db36b269a7791878df499e | |
parent | cd61d84eb1d4c387a6ec062af5d44edd8004e552 [diff] |
Reland "[Android MR] Postpone route selection until session launch" This reverts commit 74e258c6b0861b76fb8a60b6149f30dd50947648. Reason for revert: The previous revert was wrong. This is still a necessary change Original change's description: > Revert "[Android MR] Postpone route selection until session launch" > > This reverts commit 7c453583f0c622cf928bb5d628ae9def8f03279f. > > Reason for revert: This introduces some regression in some cases. The old logic works just fine so it is safe to revert. > > Original change's description: > > [Android MR] Postpone route selection until session launch > > > > Previously, we unselect and re-select the route due to CAF limitation. > > The reason is that we need to set the receiver app ID after the user > > choose a device. However CAF won't be able to know a device was selected > > after the receiver app ID gets changed. > > > > In this CL, to solve the issue, we intercept the click event in > > MediaRouteChooserDialog (which would select the route automatically). > > The route selection is postponed right before session launch. Therefore > > we are able to set the receiver app ID and select the route to get rid > > of CAF limitation. > > > > Bug: 711860 > > Change-Id: I5b1534d36d540b62199a6fb739c56ad5131c2711 > > Reviewed-on: https://chromium-review.googlesource.com/c/1351893 > > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > > Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611437} > > TBR=zqzhang@chromium.org,tguilbert@chromium.org > > Change-Id: I30322daecf8c866fdda9e846d0cb37d9a319f033 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 711860 > Reviewed-on: https://chromium-review.googlesource.com/c/1352973 > Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org> > Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611572} TBR=zqzhang@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 711860 Change-Id: I8bbeeb9e6917e07163bb0fbfacd1fa1c3f762a49 Reviewed-on: https://chromium-review.googlesource.com/c/1359822 Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613403}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .