Google Git
Sign in
chromium / infra / infra / 38227d3c18fb7433260ce1300d57b0fa29d4078b
commit38227d3c18fb7433260ce1300d57b0fa29d4078b[log] [tgz]
authorSarthak Kukreti <sarthakkukreti@google.com>Tue Mar 23 05:49:07 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 23 05:49:07 2021
tree3b83d85df8f99a6c14195a4815d129f55d22cf9f
parent738571d1a86127bdff416cb2ba392eb5d262dba6 [diff]
tls: support block-level wiping stateful partition

Adds support in TLS for wiping the stateful partition.
If ProvisionDutRequest.preserve_stateful is not set, the provisioning
code does an extra step to block-level wipe and reset the stateful
partition based on the newly provisioned image. This is done using
a clobber-state invocation that adds another reboot to the process.

BUG=b:182822167
TEST=Test provisioning with TLS+TLW; check stateful partition is
     wiped and recreated (dumpe2fs).

Cq-Depend: chromium:2762544
Change-Id: I4644bcbb68fbc49e1224a73fe81f73539258fa98
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2762517
Commit-Queue: Sarthak Kukreti <sarthakkukreti@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#39631}
2 files changed
tree: 3b83d85df8f99a6c14195a4815d129f55d22cf9f
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.