commit 38b255587ab8598eee49da1b7581646682f6d5f5
author Benoit L <lizeb@chromium.org> Tue Jul 17 02:49:59 2018
committer Commit Bot <commit-bot@chromium.org> Tue Jul 17 02:49:59 2018
tree d5b1ac36fd4a0ebffb0c514f23f9586dbbbc8948
parent ed77af3ac02fd06b844c8c3cb40ee940dacdcf35

Revert "blink/wtf: Really move MovableStrings when DCHECK_IS_ON."

This reverts commit d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b.

Reason for revert: Suspected culprit for crbug.com/863786

Original change's description:
> blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
>
> When a MovableString is parked, actually park the content, and poison
> the previous allocation. This is intended to find cached raw pointer
> accesses, which are not allowed beyond the UI thread task per the
> contract of the class.
> Enabled only when DCHECK_IS_ON to prevent potential crashes.
>
> Changes with and without DCHECK()s:
> - Cache some String properties in MovableStringImpl
> - Add a parked_strings_ to MovableStringTable for accounting, and
>   update tests accordingly.
>
> Changes with DCHECK()s:
> - Add a parked_string_ member to MovableStringImpl
> - Copy the string to the parked version in Park(), and poison the
>   previous allocation.
> - Restore the string in Unpark().
>
> Bug: 837659
> Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
> Reviewed-on: https://chromium-review.googlesource.com/1133169
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574529}

TBR=haraken@chromium.org,lizeb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837659, 863786
Change-Id: I380210859a1eed42d869c1548d0d93b0e8606e58
Reviewed-on: https://chromium-review.googlesource.com/1138873
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575530}