commit | 3a0c4853739f401a0efa9eb378b46710f5b92365 | [log] [tgz] |
---|---|---|
author | Bence Béky <bnc@chromium.org> | Fri Mar 02 13:38:51 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 02 13:38:51 2018 |
tree | cd09e85d64e53b5a8cc374c756c7370187c565c5 | |
parent | 8d95669c02840164077081876f46fcb95fc32888 [diff] |
Misc minor changes in WebSockets tests. This CL partially re-lands https://crrev.com/c/927491 among other things. This CL is mostly to prepare for adding tests for WebSockets over HTTP/2. Add missing include to spdy_network_transaction_unittest.cc for HttpResponseInfo. Change two WebSockets test file to use wildcard.pem instead of spdy_pooling.pem. Move WebSocketExtraHeadersToString from a test file anonymous namespace to websocket_test_utils.h. Also change argument type for extra headers in websocket_stream_test.cc to WebSocketExtraHeaders and use this helper function to convert them to a string. In websocket_stream_test.cc: * Change all tests to use www.example.org instead of localhost so that it is compatible with the test certificate wildcard.pem. (This is only a requirement for wss, but it is cleaner if all tests use the same hostname.) * Change tests that will be parametrized to test WebSockets over HTTP/2 as well to use wss scheme. * Change WebSocketStreamCreateUMATest to be a derived class of WebSocketStreamCreateTest instead of creating an instance of it, and use HistogramTester for simplicity. * Change test base class methods and members from public to protected. * Inline trivial AddRawExpectations() method. Bug: 801564 Change-Id: I76a3ed145baa0f9171089765852e3165d43c9710 Reviewed-on: https://chromium-review.googlesource.com/942522 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540509}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .