commit | 3b54b6aa8be4525318436d271397fc7d90c21da4 | [log] [tgz] |
---|---|---|
author | Clark DuVall <cduvall@chromium.org> | Fri Oct 12 20:54:35 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 12 20:54:35 2018 |
tree | eaf303866284ade15cd44488572fb13325c8c25c | |
parent | 8d6914220132ef83fb7ec9e18d6c2bbbb5b73f06 [diff] |
Revert "Make DataPipeBytesConsumer support ReadableStream loading better." This reverts commit c43eba9311573672d0773beed07f117d08eed09f. Reason for revert: This broke http/tests/devtools/service-workers/service-workers-navigation-preload.js on the mojo bots: Mojo Windows: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Windows/18554 Mojo Linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/20553 Original change's description: > Make DataPipeBytesConsumer support ReadableStream loading better. > > This CL fixes some edge condition interactions when being loaded as > a ReadableStream. In particular, it: > > 1. Properly distinguishes between the end of the DataPipe and a closed > DataPipe with bytes left to be read. A ReadableStream that is not > actively draining the pipe could get closed too early. > 2. Responses must support explicit completion in order to handle error > conditions properly. This CL makes DataPipeBytesConsumer wait > for an explicit signal before closing. > 3. Service worker navigation preload is updated to provide the explicit > completion signals. > > Bug: 894815 > Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1272715 > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599192} TBR=kinuko@chromium.org,mek@chromium.org,yhirano@chromium.org,wanderview@chromium.org Change-Id: Iddb6b2121a0b014b4b08c6ec64fc534820474010 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894815 Reviewed-on: https://chromium-review.googlesource.com/c/1279194 Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#599343}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .