commit | 3befe17223669abe88b4b416d558f632a9ff6ef9 | [log] [tgz] |
---|---|---|
author | Jared Loucks <jaredloucks@google.com> | Thu Jan 07 18:08:15 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 07 18:08:15 2021 |
tree | 2a1ad19103157f6d372c70d4c8410433602a97f9 | |
parent | cb04f2026fa48c6a67bd5f3b5da24f78f398298d [diff] |
Fix format of service_version sent from skylab CLI to Buildbucket. Testing: skylab-launched CTP build without change: https://ci.chromium.org/p/chromeos/builders/testplatform/cros_test_platform-dev/b8858799434862422432 skylab-launched CTP build with change: https://ci.chromium.org/p/chromeos/builders/testplatform/cros_test_platform-dev/b8858795611545629632 Bug: 1137410 Change-Id: I16e7b2bc8132a506bc1c76bb2e631ed358ec8fe9 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2614184 Reviewed-by: Sean Abraham <seanabraham@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@google.com> Commit-Queue: Jared Loucks <jaredloucks@google.com> Cr-Commit-Position: refs/heads/master@{#37378}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.