commit | 3c57b27ae1870bdedae3cf07e6b102e9927b5692 | [log] [tgz] |
---|---|---|
author | Edward Lesmes <ehmaldonado@chromium.org> | Thu Jan 07 00:29:13 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 07 00:29:13 2021 |
tree | c30e1e383d53803eb44ec1ca2e1597b31c6de0ac | |
parent | d48aa437c9e843e9d2486cdcdc9d7ba812deea40 [diff] |
Revert "presubmit: Don't print comments for missing reviewers." This reverts commit 276bab4c6e0e70789eab8bc24443c587066342b4. Reason for revert: Possible cause of crbug.com/1163731 Original change's description: > presubmit: Don't print comments for missing reviewers. > > Don't print owners comments when suggesting missing reviewers, > as this won't be supported when using Gerrit API. > > Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675 > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Bug: 1163731 Change-Id: I0b3d0f352e5483e754f6b790f70a9278df4eb3e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613924 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.