commit | 3c626e8b79666372a33a440269f414803e8f8ffe | [log] [tgz] |
---|---|---|
author | Darren Shen <shend@chromium.org> | Tue Nov 21 23:32:20 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Nov 21 23:32:20 2017 |
tree | 80d05d0a0235a25b82de8a80ac5e9234ad963081 | |
parent | 97e1b3311477de1bb4084f3267ff1afde6d61fe2 [diff] |
[css-typed-om] Allow StylePropertyMaps to take string arguments. Currently StylePropertyMaps don't support strings e.g. styleMap.set('width', CSS.px(1)) works, but styleMap.set('width', '1px') doesn't. This patch adds string support by moving parsing code to StyleValueFactory so that both CSSStyleValue.parse and StylePropertyMaps can share the parsing logic. We also do some refactoring to make handling both CSSStyleValue and strings easier. There are still some code paths that we're not sure is correct, pending clarification on GitHub: https://github.com/w3c/css-houdini-drafts/issues/512 Spec: https://drafts.css-houdini.org/css-typed-om-1/#the-stylepropertymap Bug: 545318 Change-Id: Iaef3cfad69789fc115b7e98a296eec5cb4480cd8 Reviewed-on: https://chromium-review.googlesource.com/769797 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#518443}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .