| commit | 3cb93d0aa21a7cb92b92ca169104e5efab7c295c | [log] [tgz] |
|---|---|---|
| author | Benoît Lizé <lizeb@chromium.org> | Thu Nov 15 07:38:57 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 15 07:38:57 2018 |
| tree | 12deeb86728a0b64677c94f45043cb54dec45570 | |
| parent | 1bfeb84d3a339c93e0f9b3ec60cf8e8665bc55bc [diff] |
blink/bindings: Fix false-positive ASAN warning in ParkableString. The following sequence is racy with the current ASAN checks in ParkableString, on the main thread: Park() Lock() ToString() Unlock() Park() poisons the string, ToString() unpoisons it, and Unlock() poisons it again. If this last call happens while the compression is in progress, then this is a use-after-poison. This is not a real issue, merely an overaly eager poisoning, still making using ASAN builds painful. Fix it by making sure the string stays unpoisoned during compression. Also adds a regression test. Bug: 905137,877044 Change-Id: I5276b9ae6eee4abe2f2bf041818d1ba17358a80a Reviewed-on: https://chromium-review.googlesource.com/c/1335585 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608289}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .