commit | 3e390e1cf6a97441fcdc5c5bc34f813f0053f6e9 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Wed Dec 12 22:20:20 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 12 22:20:20 2018 |
tree | d4b482d7f0e16fc073d5e1dc6435add44c9e3c1f | |
parent | 2c65b27478bbd4a73ec8e8260c7cc1d305d40071 [diff] |
trace_arguments: Mark StringStorage's move operations noexcept This fixes the GCC build after eebbd7f63c5 ("Introduce base::trace_event::TraceArguments helper class"): ../../base/trace_event/trace_event_impl.cc:61:1: error: function ‘base::trace_event::TraceEvent::TraceEvent(base::trace_event::TraceEvent&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ TraceEvent::TraceEvent(TraceEvent&& other) noexcept = default; ^~~~~~~~~~ ../../base/trace_event/trace_event_impl.cc:62:13: error: function ‘base::trace_event::TraceEvent& base::trace_event::TraceEvent::operator=(base::trace_event::TraceEvent&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ TraceEvent& TraceEvent::operator=(TraceEvent&& other) noexcept = default; ^~~~~~~~~~ With GCC, having that noexcept marker requires all members to be marked with noexcept themselves, and StringStorage was missing it. clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). Bug: 819294 Change-Id: Ie2eba30dcb6d4a5f9cc1b4b7c961af96d9f55f10 Reviewed-on: https://chromium-review.googlesource.com/c/1374230 Reviewed-by: David Turner <digit@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#616082}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .