commit | 3f0591d4f12991ed39bae2dca96d3593879be382 | [log] [tgz] |
---|---|---|
author | Edward Lesmes <ehmaldonado@chromium.org> | Thu Apr 26 20:54:22 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 16 20:01:11 2018 |
tree | e0f63522316e0a0fa0a14007146c8a8cc7048739 | |
parent | 8de3800ce55ba459ffcbedcfa52ef5e6e59caab6 [diff] |
Reland "bot_update: Patch on gclient by default." This is a reland of e38cf570fc8c0df53b576c179701efe6d683f7d2 Sinc the last reland catapult, custom-tab-client and syzygy had their origins updated to the source of truth: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1043254 https://chromium-review.googlesource.com/c/chromium/tools/build/+/1043355 This fixes the last problem we had, where the origin in gclient was different from the source of truth, and so the patch couldn't be applied. Original change's description: > bot_update: Patch on gclient by default. > > See [4] for the design doc for this change. > > We're moving the patching logic from bot_update to gclient. > This way we can test patches of dependencies that modify their DEPS > files as well, for example when ANGLE uploads a patch that modifies > DEPS files to be tested by a Chromium trybot. > > Chromium Linux CQ and Angle trybots are already running this way > (see [1] and [2]) and a PSA has already been sent [3] > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > Bug: 643346 > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: release_scripts > Reviewed-on: https://chromium-review.googlesource.com/1014356 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> Bug: 643346 Change-Id: Ia0db591c6bf9695f56e6b71777c567595986a511 Reviewed-on: https://chromium-review.googlesource.com/1031206 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.