commit | 3fe4904a00ba85fe97d3b64dee683803e8d8049b | [log] [tgz] |
---|---|---|
author | Mason Freed <masonfreed@chromium.org> | Thu Aug 23 15:21:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 23 15:21:18 2018 |
tree | d68407f72321ffa51f871bfcb626c516095ab88f | |
parent | 845a36efcd6efeed77b9bee10db633311b6edd60 [diff] |
[CI] More replacments of calls to LayoutObject.Style() with LayoutObject.StyleRef() This continues the work done in https://chromium-review.googlesource.com/c/chromium/src/+/1171144, this time expanding the set of folders considered for replacement, and the scope of the replacements. With this CL, I believe I have replaced most references to Style() with StyleRef() within these folders: - paint - layout - svg - frame Note that I only replaced immediate uses of Style(), i.e. Style()->Xyz. These are guaranteed not to cause any breakage (assuming I did the replacement well) because they already dereferenced the pointer. There are many references to Style() where the result is first checked, or where the actual pointer is passed around, and I have not touched those (yet). Perhaps for a later CL. I have also consciously not modified code in other folders (including animation, css, dom, editing, exported, html, input, layout/ng, page, and style). The reason I skipped these is that, at least for now, I am not sure that Style can always safely be assumed to be available (non-null). There are definitely cases where that can be inferred, but I didn't want to change some references in a folder and not others. Perhaps for a later CL. Bug: 872508 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie2293901477ef3ed8912582d206bdaac8fd000e1 Reviewed-on: https://chromium-review.googlesource.com/1182185 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585491}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .