commit | 402571f89e1aff1627ccf491110764c74029e3de | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Fri Oct 12 13:17:58 2018 |
committer | Noel Gordon <noel@chromium.org> | Fri Oct 12 13:17:58 2018 |
tree | 93cfe6385405ecadf0052c593c22d2415319df88 | |
parent | 863a437d0fdbbba19ad5446420b72d2f91748a72 [diff] |
Revert "Files app: Select My files when there are no volumes" This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016 Sample Failed Step: viz_browser_tests Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs Original change's description: > Files app: Select My files when there are no volumes > > Make Files app select "My files" when there are no available volumes, > this to allow Files app to behave properly when volumes subsequently > become available. > > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for > non-null |displayRoot| before trying to change to |displayRoot|. This > fixes the error "Cannot read property 'getParent' of null" when Drive > volume becomes available before Downloads volume, which is the default > volume/root. > > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so > DriveFsTestVolume can re-mount itself. > > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*" > Bug: 893161, 884967 > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702 > Reviewed-on: https://chromium-review.googlesource.com/c/1272418 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599026} Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893161, 884967, 889703 Reviewed-on: https://chromium-review.googlesource.com/c/1278063 Cr-Commit-Position: refs/heads/master@{#599190}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .