commit | 40a6cb9be79a8d05395498a705e59d50cbb77f57 | [log] [tgz] |
---|---|---|
author | Luciano Pacheco <lucmult@chromium.org> | Fri Oct 12 08:02:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 12 08:02:18 2018 |
tree | fc4daa750e8314b0b95871749ee4c71f1244a21c | |
parent | 029544dab67d79059b7610a92890091520ef7603 [diff] |
Fix naming issue when renaming files inside My files Change DirectoryModel to "unwrap" VolumeEntry when it's selected via file list. This fixes the issue where after selecting a VolumeEntry any operation in the private API would fail because it wouldn't be able to send a VolumeEntry to private API, because it requires a real Entry. This fixes the user issue of trying to rename and always getting "Use shorter name" error, even with a short name. Update FakeEntry to be an implementation of FilesAppDirEntry, since all users were using as directory, also update some functions to typing to use FilesAppDirEntry instead of FakeEntry which is more correct. Test: browser_tests --gtest_filter="*/myFilesFolderRename" Bug: 889636 Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad Reviewed-on: https://chromium-review.googlesource.com/c/1276067 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599136}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .