commit | 415b73b1a400a994a86e6f29709aa0271e895dd5 | [log] [tgz] |
---|---|---|
author | rdevlin.cronin <rdevlin.cronin@chromium.org> | Fri Nov 13 01:14:47 2015 |
committer | Commit bot <commit-bot@chromium.org> | Fri Nov 13 01:16:25 2015 |
tree | b2064603d7bcf31762c4f6f148dfc64f1953d4e9 | |
parent | 38b1bde891a3a7b98c016ef3c34f5df70183fd8e [diff] |
[Extensions] Don't allow gin::Define to be overridden Use DefineOwnProperty instead of Set in for gin, including gin::Define. Replace Set in v8_helpers as well, to avoid the same problem. Also update callsites from JS to CHECK expected arguments, rather than DCHECK (since receiving unexpected arguments likely means executing untrusted code). BUG=549986 Review URL: https://codereview.chromium.org/1433293004 Cr-Commit-Position: refs/heads/master@{#359460}