Google Git
Sign in
chromium / chromium / src / 419dc977209edd7799484e0b772d0f3aa5cd200a
commit419dc977209edd7799484e0b772d0f3aa5cd200a[log] [tgz]
authorBailey Berro <baileyberro@chromium.org>Fri Mar 09 22:30:16 2018
committerCommit Bot <commit-bot@chromium.org>Fri Mar 09 22:30:16 2018
treee3466c6b753692536e7c841ca700e533cb87d4f1
parent91d310c125df1e612442c3324b20a9eaffae15a6 [diff]
Refactor SmbFileSystem to use GetDeleteList

This change updates the DeleteEntry method on SmbFileSystem to use
GetDeleteList. When a DeleteEntry call comes in from the Files API,
SmbFileSystem first makes a call to GetDeleteList in order to get an
ordered list of entries that need to be deleted, and subsequently
calls DeleteEntry on each entry in the list.

If there is an error generating the delete_list, delete will still
be attempted on any entries in the delete_list, and the error will
be returned. Otherwise (ie generating the delete_list succeeds), the
error_code from performing the deletes willbe returned.


Bug: chromium:757625
Test: verified recursive delete still works on Eve
Change-Id: I1afb3498ee51280d70291dd31f50a550129c4381
Reviewed-on: https://chromium-review.googlesource.com/937881
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542252}
2 files changed
tree: e3466c6b753692536e7c841ca700e533cb87d4f1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .