Google Git
Sign in
chromium / chromium / src / 41b306b38a7e8b5f28add0dfb5670190a3c05862
commit41b306b38a7e8b5f28add0dfb5670190a3c05862[log] [tgz]
authorMarc Treib <treib@chromium.org>Wed Dec 05 09:28:25 2018
committerCommit Bot <commit-bot@chromium.org>Wed Dec 05 09:28:25 2018
tree8c335673e997034b729ad3514341ed14cbd32c48
parent84d989af7b54497c435347b4e9d6c84114c8b5e2 [diff]
sync_ui_util: Use SyncService rather than ProfileSyncService

Generally, everything should use the interface (SyncService) rather than
the concrete implementation (ProfileSyncService). In particular, this
will make it easier to write tests for this code, since they can now use
TestSyncService instead of ProfileSyncServiceMock.

Bug: 884159, 910518
Change-Id: I794e0af45b4fc576536265cbc049358d37196cbd
Reviewed-on: https://chromium-review.googlesource.com/c/1357087
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613916}
4 files changed
tree: 8c335673e997034b729ad3514341ed14cbd32c48
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .