commit | 41b5497b95c2bc02d527aa4154d4f531e45a0303 | [log] [tgz] |
---|---|---|
author | Scott Violet <sky@chromium.org> | Wed Aug 15 04:14:35 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Aug 15 04:14:35 2018 |
tree | 6d976394517092e44f81e4db4fbd07ce35d84cc5 | |
parent | ad99c323336b00fc3677cdf3da3d38085e24329b [diff] |
chromeos: gets more ash_unittests working with single-process mash The OverviewButtonTrayTests need to set the keyboard devices *after* AshTestBase::SetUp() is called. This is is important in single-process mash as Ash is the one creating the Env that the keyboard devices us. In non-single-process-mash AshTestSuite is creating the Env these tests use. The case ShellTest2.DontCrashWhenWindowDeleted is exercising is different enough for single-process mash that I created a separate test. Adding NOPRESUBMIT=true as this bot passed the trybots, and we're ok with this test including Env::GetInstance(). NOPRESUBMIT=true BUG=847992 TEST=test only changes Change-Id: I0543db96ca9aa910340360d8da3e6aafcda34d7f Reviewed-on: https://chromium-review.googlesource.com/1174978 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#583161}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .