| commit | 428fe8270070a23f1958f6bfb201c2655b79157f | [log] [tgz] |
|---|---|---|
| author | Xinan Lin <linxinan@chromium.org> | Tue Apr 20 19:25:02 2021 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 20 19:25:02 2021 |
| tree | 3d0aa808d4893bbc6a22862751587e59d846a0f0 | |
| parent | 2d764e69cf4e54180986e7d57ca79507e018f800 [diff] |
Reland "Verify the arguments for WebRTCPerfTest" The first attempt failed because we dropped perf_id, as the perf dashboard has deprecated it. However, our local test runner still requires perf_id before it uploads the metrics*. Coupling with crrev.com/c/2830211, this CL reads the perf_id from source side configuration and passes it to test runner. *: Another CL will update perf_id in test runner to perf_builder_name_alias to reduce the confusion. Original change's description: > Verify the arguments for WebRTCPerfTest > > This is an intermediate CL prior to a full migration of WebRTCPerfTest. > Before we completely remove the recipe side conf for test_spec, we > need to verify the specs from source side are consistent. > > BUG=chromium:1137047 > TEST=led launch > > Change-Id: I01c2ac5c63808d4224ca097ef3c4db6ecd063bb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2786330 > Commit-Queue: Xinan Lin <linxinan@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> BUG=chromium:1137047 TEST=led launch Change-Id: I9daba6a754d063a55559ac6cf950380461795a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2830024 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in the recipes directory), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.