commit | 445d9eb4484577b2219d8d8e67dbedcee9804219 | [log] [tgz] |
---|---|---|
author | Scott Violet <sky@chromium.org> | Wed Dec 19 21:23:19 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 19 21:23:19 2018 |
tree | ff93c0b6b20bf6ffd5cefd040a5444ab9762c1fb | |
parent | 8dd3e1214aa755a011aa25ececeb06826ed4dff7 [diff] |
chromeos: fixes BrowserFinderChromeOSTest.FindBrowserOwnedByAnotherProfile for mash. This test was creating an aura window, which is problematic for the mash case and MultiUserWindowManager. In particular, MultiUserWindowManager calls over mojo, and the ash side ignores calls to non-top-level windows. Because the test creates an aura::Window directly the window isn't a top-level and ash was ignoring the MultiUserWindowManager calls. The fix is to create a views::Widget, which is a top-level, so that ash doesn't ignore the request. This also adds a call to FlushBindings() to ensure some async processing completes before the assertions. I would like to replace usage of TestBrowserWindowAura, with TestBrowserWindowViews, but that can be done separately. BUG=910241 TEST=test only change Change-Id: I2e6ccd86c4c39ae441c99efad82de43308ff4ae8 Reviewed-on: https://chromium-review.googlesource.com/c/1384657 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#617950}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .