Remove BreakAlways from EBreak enum
This change is the first step in preparing EBreak for automatic
generation.
The EBreak enum currently has three kinds of values:
* Values applicable to break-before & break-after property
* A subset of these applicable to break-inline
* A single value BreakAlways applicable to neither and only used
temporarily in the code path for computing values for the properties
page-break-before|after|inline and
-webkit-column-break-before|after|inline.
This change removes the last bullet point. The next stage will split the
other two into separate enum classes with standardized naming.
Reasons to feel confident about removing BreakAlways:
* There are existing DCHECKs ensuring that it is never set in
ComputedStyle (removed in this CL).
* CSSValueAlways (the only thing that maps to it) is excluded from the
list of allowed values for break-before|after|inline in
CSSParserFastPaths.cpp.
* For the legacy properties (page|-webkit-column)-break-(before|after),
CSSPropertyParser.cpp converts CSSValueAlways to either CSSValuePage
or CSSValueColumn as appropriate (and CSSValueInvalid for
*-inside properties).
I have replaced the temporary use of BreakAlways within
ComputedStyleCSSValueMapping.cpp with an equivalent direct conversion to
appropriate CSSValues. (This seems more consistent with the rest of
ComputedStyleCSSValueMapping.cpp anyway.)
BUG=628043
Review-Url: https://codereview.chromium.org/2677033002
Cr-Commit-Position: refs/heads/master@{#449474}
4 files changed