| commit | 468109cc91a8c236f4e74bd9e2dd094db5464d57 | [log] [tgz] |
|---|---|---|
| author | alexmos <alexmos@chromium.org> | Mon Apr 17 23:47:38 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Apr 17 23:47:38 2017 |
| tree | add375921a1777b148baa87653072bbbc1b10aeb | |
| parent | c236847d7da49e1799cc64d9decb77e92a3995f4 [diff] |
Revert of Improve canonicalization of mailto url path components (patchset #2 id:20001 of https://codereview.chromium.org/2817213002/ ) Reason for revert: appears to be breaking fast/url/mailto.html on at least the Mac bots: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/32726 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12/builds/1614 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/45169 diffs: -PASS canonicalize('mailto:addr1, addr2') is 'mailto:addr1, addr2' +FAIL canonicalize('mailto:addr1, addr2') should be mailto:addr1, addr2. Was mailto:addr1,%20addr2. Original issue's description: > Improve canonicalization of mailto url path components > > The canonicalization of the path component of mailto urls is too lax, leading to > information disclosure and possible command injection attacks against mail > clients. To fix this, we will percent-encode more characters in the path > component of mailto urls, matching other browsers. > > BUG=711020 > TEST=url_unittests > > Review-Url: https://codereview.chromium.org/2817213002 > Cr-Commit-Position: refs/heads/master@{#465046} > Committed: https://chromium.googlesource.com/chromium/src/+/484ff36cdcb8dcf5efa999a471d1d509c0a8a5f2 TBR=brettw@chromium.org,elawrence@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711020 Review-Url: https://codereview.chromium.org/2823883005 Cr-Commit-Position: refs/heads/master@{#465063}