Google Git
Sign in
chromium / chromium / src / 46c535d207b3648ddefdf3f9a588b69ac5ef31f2
commit46c535d207b3648ddefdf3f9a588b69ac5ef31f2[log] [tgz]
authorGabriel Charette <gab@chromium.org>Sun Dec 03 12:14:01 2017
committerCommit Bot <commit-bot@chromium.org>Sun Dec 03 12:14:01 2017
tree2918a85ece70c2750d60f914b3ca67b044c5183e
parent4bc282bbe092ab36b1206a09926ba09775669ea4 [diff]
Make RunLoop::Delegate methods public.

This mimics the pre-existing paradigm for MessagePump::Delegate :
public methods on Delegate which are then privately inherited.

There were cr-dev discussions on these topics (composition vs private
inheritance) but I don't see a reason to deviate from the
pre-established MessagePump paradigm here.
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/XdsXTHy9lis/discussion
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/CwzjcWd9cYM/discussion

I did consider composition here (e.g. with a private RunDelegate
class in MessageLoop, but the many outer_-> in
Run/Quit/EnsureWorkScheduled made it ugly.

R=danakj@chromium.org

Bug: 708584
Change-Id: I42830b3a28d29b1a518db4cfc767a655de491a90
Reviewed-on: https://chromium-review.googlesource.com/798290
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521227}
1 file changed
tree: 2918a85ece70c2750d60f914b3ca67b044c5183e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .