Revert of Re-enable SitePerProcessBrowserTest.CrossSiteIframe (patchset #10 of https://codereview.chromium.org/479403004/)
Reason for revert:
This is causing unaddressable memory errors on the DrMemory full bot. Build where the error was introduced:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/945
(error hash: 25DFC5E3C30FC6B7)
Sample log output:
UNADDRESSABLE ACCESS of freed memory: reading 0x034348e0-0x034348e4 4 byte(s)
# 0 blink_web.dll!blink::toCoreFrame [third_party\webkit\source\web\webframe.cpp:24]
# 1 blink_web.dll!blink::RemoteFrameClient::firstChild [third_party\webkit\source\web\remoteframeclient.cpp:49]
# 2 blink_web.dll!blink::WebRemoteFrameImpl::~WebRemoteFrameImpl [third_party\webkit\source\web\webremoteframeimpl.cpp:106]
# 3 blink_web.dll!blink::WebRemoteFrameImpl::close [third_party\webkit\source\web\webremoteframeimpl.cpp:131]
# 4 content.dll!content::RenderFrameProxy::~RenderFrameProxy [content\renderer\render_frame_proxy.cc:120]
# 5 content.dll!content::RenderFrameProxy::`vector deleting destructor'
# 6 content.dll!content::RenderFrameProxy::OnDeleteProxy [content\renderer\render_frame_proxy.cc:180]
# 7 content.dll!content::MessageRouter::RouteMessage [content\common\message_router.cc:54]
# 8 content.dll!content::MessageRouter::OnMessageReceived [content\common\message_router.cc:46]
# 9 content.dll!content::ChildThread::OnMessageReceived [content\child\child_thread.cc:494]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage [ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run [base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask [base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask [base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask [base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork [base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run [base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler [base\message_loop\message_loop.cc:408]
#18 content.dll!content::RendererMain [content\renderer\renderer_main.cc:227]
#19 content.dll!content::RunNamedProcessTypeMain [content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run [content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain [content\app\content_main.cc:19]
#22 content::LaunchTests [content\public\test\test_launcher.cc:475]
#23 main [content\test\content_test_launcher.cc:123]
BTW IMHO the CL summary for this change could be better, this change did way more than re-enalbe a test. Ideally the summary would capture the entirety of the change.
Original issue's description:
> Re-enable SitePerProcessBrowserTest.CrossSiteIframe
>
> This CL fixes a few issues in the cross-process subframe navigation and re-enables the CrossSiteIframe test on most platforms. There are still some issues on ChromeOS and Android, which will be investigated and fixed in follow-up CL.
>
> BUG=399775, 357747
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291437
TBR=creis@chromium.org,avi@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399775, 357747
Review URL: https://codereview.chromium.org/515073002
Cr-Commit-Position: refs/heads/master@{#292336}
16 files changed
