commit | b31c9aa77f4ab68acbfc4b2a01216ec0f42e07c9 | [log] [tgz] |
---|---|---|
author | kolos <kolos@chromium.org> | Wed May 31 12:42:55 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 31 12:42:55 2017 |
tree | 2ede677c85760072b1b7ba620e5cc78832b9af80 | |
parent | 476d6743b4fc42dd2a2bcf3664642c4884a70cc0 [diff] |
[Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr Before this CL, |pending_login_managers_| was an array of unique_ptr. So, we have to pass ownership to | PasswordsClientUIDelegate|. When manual fallback for password saving is implemented, both PasswordManager and PasswordsClientUIDelegate should have access to the PasswordFormManager. Another issue that this CL fixes: the matched PasswordFormManager is removed from |pending_login_managers_| on form submission (https://cs.chromium.org/chromium/src/components/password_manager/core/browser/password_manager.cc?rcl=2f63ef02c274ccc73241c9723ffc3edb94f7529e&l=356). If the login has failed, we might still need that PasswordFormManager in |pending_login_managers_| and have to re-create it. BUG=725883 TEST=PasswordManagerTest.InPageNavigation Review-Url: https://codereview.chromium.org/2900693002 Cr-Commit-Position: refs/heads/master@{#475889}