commit | 48471218ba9ad3dffcd7657b670dfc17c5638022 | [log] [tgz] |
---|---|---|
author | arthursonzogni <arthursonzogni@chromium.org> | Thu May 24 22:34:53 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 24 22:34:53 2018 |
tree | c1d2617d343e3880c78b32b03aaa6942688df2c1 | |
parent | 2945468b7ca2c2129b13d911dc45c4c0e69c74ac [diff] |
Fix race condition in frameElement.html. I am working on https://crbug.com/831155. Some tests that are relying on how things are scheduled in Blink are failing. There was a race condition in this test. The iframe "#fr2" was asked to navigate to a first URL, but soon after, a javascript function modifies the iframe.src to navigate elsewhere. What happened when it didn't work? 1) The first navigation starts. 2) The second navigation is scheduled (See blink's NavigationScheduler) 3) The first navigation commits. FrameLoader::CommitProvisionalLoad() executes: frame_->GetNavigationScheduler().Cancel(). It cancels the second navigation. This CL fixes the race condition. Bug: 831155 Change-Id: I2dd951140b4c5a671c749348ca0247f1901d8b77 Reviewed-on: https://chromium-review.googlesource.com/1069013 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561659}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .