commit | 48f0d0c8530840f17718c7185ad15d479fa38f4d | [log] [tgz] |
---|---|---|
author | Darwin Huang <huangdarwin@chromium.org> | Wed Oct 31 19:40:05 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 31 19:40:05 2018 |
tree | b97ab4f37b58e7cbf8854419ea6f011a7f801dd2 | |
parent | 961890d8726e1e49e939fa0d7dd693b6b8a1ae78 [diff] |
Renderer: Refactoring Frame DocumentAttached/DidAttachDocument (and spellfix) - Renamed DocumentAttached() to DidAttachDocument() so that function names better express what the function is trying to accomplish - Remove extraneous GetDocument() calls - Spellfixing "I think that DocumentAttached(..) is misleading, since it seems to imply that it's going to find out whether a document is attached and return a boolean representing that. Instead, it's in essence attaching to a document (or rather the document’s context, but with some clearing and such going on as well). Therefore, I'm thinking of perhaps renaming DocumentAttached(..) to AttachDocument(..) or AttachToDocument(..) in another CL." -Darwin in another CL Bug: 896479 Change-Id: I4b9e2cd9a998f2b18acdbca9e2339c7ca5a124e8 Reviewed-on: https://chromium-review.googlesource.com/c/1300680 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604366}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .