Google Git
Sign in
chromium / chromium / src / 490c27babbe440762253c71c8ddc2438d3814d0e
commit490c27babbe440762253c71c8ddc2438d3814d0e[log] [tgz]
authorJulie Jeongeun Kim <jkim@igalia.com>Sat Aug 11 03:37:47 2018
committerCommit Bot <commit-bot@chromium.org>Sat Aug 11 03:37:47 2018
tree4a60b160eba77f427c40252c99b46f02437081ea
parent4c172804c44cf480776c1acfb741e756bbf7cb1e [diff]
Deliver bounds information to CreateTooltipWidget

When 'CreateTooltipWidget' creates 'Widget' for tooltip and
initializes it, it needs its bounds at InitParams. If it
doesn't have the bounds information, some platform widgets
get crashed and DesktopWindowTreeHostX11 keeps
|sanitized_params| to avoid this case.

This patch delivers the bounds for the tooltip widget and
adds DCHECK to find what causes the empty bounds.

Bug: 849585
Change-Id: I3de067a917e4343bab642c3a1b13434b6cfaeee0
Reviewed-on: https://chromium-review.googlesource.com/1086820
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#582426}
3 files changed
tree: 4a60b160eba77f427c40252c99b46f02437081ea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .