| commit | 494a88f6f8c345512a5dbb9136ca99ab10bc6dd5 | [log] [tgz] |
|---|---|---|
| author | Gary Miguel <garymm@google.com> | Mon Sep 23 16:30:02 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Sep 23 16:30:02 2019 |
| tree | 56fd3577002e9560892e27fbbd6c2577c6a47bfc | |
| parent | e8d0b68df47a63f3a184f64c138404a139e046ed [diff] |
Convert entire tricium Results message to JSON only once Previously we were putting a JSON string inside the Results.Comments field. This was esentially double-serializing that one field, which caused errors when the server tried to deserialize. Also remove the "dump" argument, since it doesn't seem useful. Fuchsia-Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=36225 Change-Id: I8aae0e51a9f77c793edd99d86631d9103752fe4d Recipe-Nontrivial-Roll: fuchsia Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1817254 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Auto-Submit: Gary Miguel <garymm@google.com>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.