commit | 497a616eccb04d08841535091b1ab4c9c3599a72 | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Thu Dec 06 20:35:48 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 06 20:35:48 2018 |
tree | 034206d4249b7d3f1b19fd9a078262e7aa087403 | |
parent | f72a62734e82e6930428116ab1f39692ec163c2a [diff] |
Make WebWidget methods on WebView private. Callers should go through WebView's MainFrameWidget() to get to them. While WebViewImpl inherits privately from WebWidget, the overrides of its methods were all public. This moves them to the private section with the single exception of GetPagePopup(). This method probably belongs on WebView, but WebViewImpl changes its return type, so it's harder to simply move mechanically. A TODO is left for that one. This change is mechanical and not opinionated. All callers that failed to compile are simply switched to call MainFrameWidget()-> in order to get to the methods. R=dcheng@chromium.org Change-Id: I44cb270a97f3a4034f00c00631dad8631678ef53 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1363855 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#614479}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .