Google Git
Sign in
chromium / chromium / src / 4aa413c4ca7a441cf0ca2bb5116c672745148334
commit4aa413c4ca7a441cf0ca2bb5116c672745148334[log] [tgz]
authorArthur Hemery <ahemery@chromium.org>Mon Jan 14 18:53:30 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 14 18:53:30 2019
tree9cc8c1241e5666b86393c7963bbc79a006044c92
parentbe33ae99520fae290262b679c2455d33cf1c38d2 [diff]
Navigation: Adding StartWithParams to NavigationSimulatorImpl - 1/2

This patch implements the first content specific NavigationSimulator
usage, support for LoadURLWithParams. We provide a SetLoadURLParams,
that if provided, will be used when starting the navigation.

This new capability also allows us to remove all direct calls of
LoadURLParams to unit tests. The only remaining ones in
navigator_impl_unittest.cc that are quite more complex than these
will be handled in a followup of this patch, here:
https://chromium-review.googlesource.com/c/chromium/src/+/1409196


Bug: 728571
Change-Id: Iaada51795c3edb4e906f8ff6d819f1e417f8010a
Reviewed-on: https://chromium-review.googlesource.com/c/1404088
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622537}
6 files changed
tree: 9cc8c1241e5666b86393c7963bbc79a006044c92
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .