commit 4b937d53836386e51532fbe870938b33ce0455ed
author Moe Ahmadi <mahmadi@chromium.org> Thu Jul 12 20:13:40 2018
committer Commit Bot <commit-bot@chromium.org> Thu Jul 12 20:13:40 2018
tree dac8068438913b36a44ba60fab8940b6be2e8ee6
parent d54b58e5b08b96664080795a01e0bd2373952e6e

Revert "[AF][IOS] Scan page for form changes when a field is focused"

This reverts commit 77318515062e22c6dbcb5b4ae8c6daa4ef70d5b9.

Reason for revert:
This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its current implementation Autofill::OnFormsSeen is only intended to be called on page load.

Original change's description:
> [AF][IOS] Scan page for form changes when a field is focused
>
> This CL fixes a regression caused by crrev.com/c/1012979. Previously,
> AutofillAgent would scan the whole page on form activities due to the
> possiblity of Autofill having been enabled after page load.
> crrev.com/c/1012979 replaced that logic in favor of observing the Pref
> directly. This has a side effect where previously hidden fields can go
> unnoticed by AutofillManager. This CL fixes that regression by scanning the
> page when a field is focused. All fields receive focuse before their value
> is set by Autofill, therefore, AutofillManager can get notified of
> previously hidden fields.
>
> Bug: 855696
> Change-Id: I175bf90e12d1ca356b746e6347943a295063c288
> Reviewed-on: https://chromium-review.googlesource.com/1112493
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570713}

TBR=olivierrobin@chromium.org,mahmadi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855696, 860225
Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c
Reviewed-on: https://chromium-review.googlesource.com/1135671
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574698}