commit | 4c128f608caf21eacfeeddbaa8e98df01de9d842 | [log] [tgz] |
---|---|---|
author | Jacob Kopczynski <jkop@google.com> | Wed Jan 06 21:54:31 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 06 21:54:31 2021 |
tree | 967acb1a8feb2646a213c47c519254128c3aa1d0 | |
parent | f60685747798d9ddd8906a0981cf9e74fbc0887c [diff] |
Move python script to ordinary code Unclear why this was shelling out to a opaque process rather than using existing step code, but it made this bug harder to diagnose and is probably unnecessary. Bug: chromium:1162505 Change-Id: I7723a351b2544acb0c7828afd1c72f5e47c03beb Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2612057 Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.