Google Git
Sign in
chromium / chromium / src / 4d670994fe15465ee7f3057038077de007bd40a3
commit4d670994fe15465ee7f3057038077de007bd40a3[log] [tgz]
authormanuk <manukh@chromium.org>Fri Feb 08 18:49:38 2019
committerCommit Bot <commit-bot@chromium.org>Fri Feb 08 18:49:38 2019
treedec375892b7816e659b571e3e43b512736ad4b34
parentfadc3c473c6b18901f701c51cd2aa44fefc0b241 [diff]
[omnibox chrome:omnibox]: Use header tooltip when searching boolean properties.

Before, we used the column header text when searching by boolean properties.
When we replaced the headers with 1 letter abbreviations, this broke searching
boolean properties. I.e., to search for results that could be the default match,
you'd have to type 'is:d', but 'is:default' would no longer work. This CL
changes searching to use the first line of the tooltip text instead of the
header text.

The current tooltip names are:
  - Can be Default
  - Starred
  - Has Tab Match
  - deletable
  - From Previous
  - Done

Bug: 891303
Change-Id: Ic275924ca3e7dfad6fba3c20514e87577bbbf807
Reviewed-on: https://chromium-review.googlesource.com/c/1459782
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630398}
1 file changed
tree: dec375892b7816e659b571e3e43b512736ad4b34
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .