commit | 4daa1195ef9ae96b9ffb20c0126ba011913cc737 | [log] [tgz] |
---|---|---|
author | Victor Costan <pwnall@chromium.org> | Wed May 02 21:22:00 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 02 21:22:00 2018 |
tree | affe0bf93fe0ad8d0cc0db1d1029b92ddd210845 | |
parent | c0f801e2412d54a42df0694363e7796cc47403ae [diff] |
ServiceWorker: Rename OnRegistrationStored -> OnRegistrationCompleted. For historical reasons, OnRegistrationStored() is called when the promise returned by ServiceWorkerContainer.register() is resolved, which happens before the registration is written to disk. This means OnRegistrationStored() implementations cannot assume that ServiceWorkerContextCore will be able to retrieve the registration. This CL renames the method to a more appropriate name. A follow-up CL will add an OnRegistrationStored() method, which will be called when the registration is written to the database. TBR=benwells Bug: 729800 Change-Id: If273b3008ff55e4d5cd8f5be9e0e6090da2e5390 Reviewed-on: https://chromium-review.googlesource.com/1039083 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555550}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .