Google Git
Sign in
chromium / chromium / src / 4f4311036e62cd2d059573b3ee4688fadb83ec6d
commit4f4311036e62cd2d059573b3ee4688fadb83ec6d[log] [tgz]
authorMarc Treib <treib@chromium.org>Thu Oct 18 09:41:53 2018
committerCommit Bot <commit-bot@chromium.org>Thu Oct 18 09:41:53 2018
tree8ce904f3502dfeb4f6ce08c9247c80f4ca17f90d
parent55e3f84e68f754ac02daa9fb2863f28cdc400afa [diff]
Cleanup: Make SyncServiceCrypto Reset()able

In some circumstances, ProfileSyncService wants to fully reset
SyncServiceCrypto's state. Currently, it destroys and recreated the
whole object. That works, but it's problematic if we want to pass
pointers to the SyncServiceCrypto object elsewhere.
Instead, this CL adds a Reset() method to SyncServiceCrypto. For
convenient implementation, and to make sure *everything* gets reset,
all the mutable state gets wrapped into a new struct.

Bug: 884159
Change-Id: Ia2590301a6236461e4df20d7f83fee5599e5483c
Reviewed-on: https://chromium-review.googlesource.com/c/1286424
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600705}
4 files changed
tree: 8ce904f3502dfeb4f6ce08c9247c80f4ca17f90d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .