Google Git
Sign in
chromium / chromium / src / 4f4f3ac567ed9797b4456ba8d1f4a10844d759e1
commit4f4f3ac567ed9797b4456ba8d1f4a10844d759e1[log] [tgz]
authorJan Krcal <jkrcal@chromium.org>Fri Sep 21 08:22:09 2018
committerCommit Bot <commit-bot@chromium.org>Fri Sep 21 08:22:09 2018
treef0c94c84858a23f0c47c99b0ce5318653678e0ca
parent49de68e4998ac67b875a78c7ca7b043062d41b6a [diff]
[AF Wallet] Test histograms for the wallet data bridge

This CL adds histogram checks into unit-tests for the autofill wallet
data bridge. Apart from verifying we send correct metrics, this also
checks that we write to DB only when needed. Since this was previously
untested, this new check revealed a minor typo in one of the tests.

This CL also prepares ground for a follow-up CL that refines wallet
data notifications (i.e. makes the information previously only revealed
to metrics also available to observers).

Bug: 853688
Change-Id: Ia17d54ff81f1d04316c10d6ef548b20e3d8a9905
Reviewed-on: https://chromium-review.googlesource.com/1236275
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593115}
1 file changed
tree: f0c94c84858a23f0c47c99b0ce5318653678e0ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .