commit | 4fb927c087d54d5ff8993c2be15e72fe9c05f9b4 | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Tue Dec 04 23:02:10 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 04 23:02:10 2018 |
tree | d8f9509470b9ca71898077116c1cb60c42d9b102 | |
parent | 4ec7a602dbf361db2c61e743a8ebfb97c87eef8a [diff] |
Don't send PageMsg_WasShown from RenderFrameHostManager::CommitPending() This was done to show the Page which was hidden accidentally when hiding the main frame's RenderWidgetHost when detaching a main frame. Detaching a main frame doesn't destroy the RenderWidgetHost because the renderer's RenderWidget's lifetime is tied to RenderView. Now the Page is no longer hiding with the main frame RenderWidget so this code does not need to show the Page when creating a subframe in a tree that was empty but used to hold a local main frame. Lots of investigation/details in crbug.com/908582 from #15 to #19. R=alexmos@chromium.org, creis@chromium.org Change-Id: Ie03115c94883c2a19840f7b9e16fc4c94789ede2 Bug: 419087, 908582, 638375 Reviewed-on: https://chromium-review.googlesource.com/c/1357629 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#613740}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .