Google Git
Sign in
chromium / infra / infra / 50a424e6a8b53fb9f18a28e977e0c015b372228a
commit50a424e6a8b53fb9f18a28e977e0c015b372228a[log] [tgz]
authorOwen Rodley <orodley@chromium.org>Thu Mar 25 04:29:47 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 25 04:29:47 2021
tree42a0b6f8f6885985fc69410f021865206262d58d
parentb15c7718399539b459276cefcd72c91684e506ac [diff]
Update the 3PP cpython3 package for Python 3.9.

I've kept it compatible with 3.8 in case we need to do a patch update of
that version. I've confirmed that the latest 3.8 and 3.9 build on Linux
after this CL.

Two changes were necessary to get 3.9 building:

* In patch 0002, one of the context lines changed slightly in 3.9. To
  get the patch to apply cleanly under both versions we just reduce the
  amount of context by one line to get rid of the changed line.
* In python_mod_gen.py, distutils.core is no longer importable under
  3.9, as it now depends on subprocess. We apply the same hack as in
  setup.py, importing _bootsubprocess as subprocess before importing
  distutils. We keep it compatible with 3.8 by doing nothing if the
  import fails.

Bug: 1176014
Change-Id: I002ff3088c658a55c53b28e0669e5d0357a53082
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2784173
Auto-Submit: Owen Rodley <orodley@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Owen Rodley <orodley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#39712}
3 files changed
tree: 42a0b6f8f6885985fc69410f021865206262d58d
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.