Google Git
Sign in
chromium / infra / infra / 5111a653a00cea76ce42b76f63e6efdf00aafe89
commit5111a653a00cea76ce42b76f63e6efdf00aafe89[log] [tgz]
authorCongbin Guo <guocb@chromium.org>Tue Apr 13 20:03:29 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 13 20:03:29 2021
tree2737ebb66465b41141063d5f63c879be3e4844ce
parenta003f9e2d6882808174d5ac3543b1051f43873a0 [diff]
Revert "caching-backend: conf-creator: wait until the node is configured in UFS"

This reverts commit da77f51f650bfbac7229647057c8e2717d46dcc7.

Reason for revert: This CL blocks the normal dasemonset rolling out since PODs will not be in Running state if not configured in UFS.

Original change's description:
> caching-backend: conf-creator: wait until the node is configured in UFS
>
> As the init container of caching backends, right now conf-creator
> creates some non-operational conf files for Nginx and keepalived when
> the node is not configured in UFS yet. After the UFS configuration done,
> we have to restart the POD.
>
> With this patch, it will not exit until the node is configured.
>
> BUG=None
> TEST=Built and ran locally with fake 'NODE_IP' and 'NODE_NAME' to
>     verify the behavior is as expected, i.e.
>
> Change-Id: I51568b68096b96b4fe5dbec5117fd7a4bf4fc4fa
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2808700
> Commit-Queue: Congbin Guo <guocb@chromium.org>
> Auto-Submit: Congbin Guo <guocb@chromium.org>
> Reviewed-by: Allen Li <ayatane@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#39958}

Bug: None
Change-Id: Ie16000b4c9964e8ee09d5a8ba87f60bfec69a52b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2811978
Auto-Submit: Congbin Guo <guocb@chromium.org>
Reviewed-by: Sanika Kulkarni <sanikak@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#40127}
3 files changed
tree: 2737ebb66465b41141063d5f63c879be3e4844ce
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.