commit | 514e34fa47261afc25fd6f732c7d8628df1ca7ba | [log] [tgz] |
---|---|---|
author | Samuel Huang <huangs@chromium.org> | Thu Dec 13 14:33:25 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 13 14:33:25 2018 |
tree | e9c68f44d6000324f88c9334cd94a8a0e468e2ad | |
parent | 47ddfcfb6e439e6a1f0a8487cd4e870ae573ab12 [diff] |
[SuperSize] Fix missing sizes in LinkerMapParserTest.test_Parser(). LinkerMapParserTest.test_Parser() creates an iterator of processed test .map file. Previously this iterator was shared between calls to (1) DetectLinkerNameFromMapFile(), (2) .MapFileParser().Parse(). This causes a bug in the test: (2) requires a fresh iterator, and it explicitly it skips the first line! Consequently, a number of section sizes ({.interp, .ARM.exidx, .dynsyn}) were missing. This CL fixes the test by creating fresh iterators for (1) and (2). Also, the section sizes are sorted to reduce arbitrariness of dict iteration. Bug: 892648 Change-Id: Ib52f17b0446012fe37951c86409c450d59b57e4a Reviewed-on: https://chromium-review.googlesource.com/c/1375610 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#616304}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .