Google Git
Sign in
chromium / chromium / src / 5179de1579a818b685d09934d32d137b6bb376fb
commit5179de1579a818b685d09934d32d137b6bb376fb[log] [tgz]
authorCharles Harrison <csharrison@chromium.org>Wed Dec 06 19:44:17 2017
committerCommit Bot <commit-bot@chromium.org>Wed Dec 06 19:44:17 2017
tree57d83236542b0b038af35faac0c088a0c5be9c92
parentfc89e8f72e41fb56e11c1ecc14a04054f54187c5 [diff]
[tab_under] Add click through metrics for desktop

This CL abstracts some logic for "click position" to be shared by
both the popup tab helper, and the framebust tab helper.

Additionally, it stores a closure on the framebust tab helper to be
associated with each individual entry. This is used to collect metrics
for tab-under blocking on desktop.

Bug: 661629
Change-Id: Ibdc043c1d3068c38dad304be42b2d48133b3f21e
Reviewed-on: https://chromium-review.googlesource.com/809098
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522171}
16 files changed
tree: 57d83236542b0b038af35faac0c088a0c5be9c92
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .