| commit | 51c186dd983e542d2ac17835f73df8b1e5c6461e | [log] [tgz] |
|---|---|---|
| author | adamk <adamk@chromium.org> | Thu Aug 25 16:59:12 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Aug 25 16:59:45 2016 |
| tree | 0d1e2dcd785bf37ffba918cacfd0b67fd47a95a2 | |
| parent | 2a97b1bcb16a905ae4c10ba11f8efdfe5e2b9946 [diff] |
Centralize and standardize logic for ExpressionClassifier accumulation Previously the calls to ExpressionClassifier::Accumulate() each chose slightly different sets of productions to accumulate, and it turned out that these were in some cases broader than needed and in some cases less broad. The existence of some grab-bag production bitmasks like ExpressionClassifier::ExpressionProductions made this situation more error-prone (for example, that production was missing AsyncArrowFormalParametersProduction). This patch removes all "grab-bags" besides AllProductions. In some of the places where code was using those grab-bags for convenience, it switches them to use negation of AllProductions. In other, specifically those having to do with expressions that are disallowed anywhere in a sub-expression of a parameter list, I've added a new method on ExpressionClassifier to centralize the logic. The aforementioned centralization/addition of AsyncArrowFormalParametersProduction fixes several cases where we were failing to report an error for 'await' in some contexts; I've added those test cases. The patch also narrows all cases to exactly the set or productions necessary, with a comment on each explaining the choice. BUG=v8:4483 Review-Url: https://codereview.chromium.org/2271063002 Cr-Commit-Position: refs/heads/master@{#38918}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.