commit | 53e8b2a294d66219b5c4daf00dda1cb9f822a54f | [log] [tgz] |
---|---|---|
author | Oystein Eftevaag <oysteine@google.com> | Thu Nov 29 21:32:46 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 29 21:32:46 2018 |
tree | b76379c1ed1195f1202fb17cff9fea783724e837 | |
parent | 1f132c9c1298694d83017f771e1917e6fdd63089 [diff] |
Perfetto: Stop splitting _COMPLETE events The current Perfetto backend splits _COMPLETE trace events into separate _BEGIN and _END pairs, as it's not very feasible to modify existing events after they're written into the Shared Memory Buffers. This is causing some issues with the trace-viewer which has some assumptions about the ordering of begin/end events vs. async events, and is also bloating the sizes of traces and adding extra overhead for the perf infra. Instead, we now keep the _COMPLETE events in an internal stack in TLS and only emit them when we have their duration. R=eseckler@chromium.org,skyostil@chromium.org Bug: 909728,888558 Change-Id: I80e37264de66d8bbcb6c9095d21047957fd6eb9f Reviewed-on: https://chromium-review.googlesource.com/c/1354503 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#612360}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .