commit | 53f46b89a44013ec4ffece80fe3f1f044e4a4f49 | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Tue Dec 11 20:55:55 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 11 20:55:55 2018 |
tree | 1eb1c7b0f05955721b02c4d097e52fb00a0d477d | |
parent | 726998964292ce7e1f7f860788be3bc52e66c4ea [diff] |
Remove ScheduleAnimation plumbing in WebFrameWidget/WebView/LayerTreeView. Have ChromeClient go directly to WebWidgetClient instead of through the WebFrameWidget. The WebFrameWidgetImpl would go either to the compositor (which always exists) or to WebWidgetClient. The latter path was dead. Similar in WebViewImpl. Then when ChromeClient (via plumbing..) would ping the compositor, it would callback to RenderWidget to say RequestScheduleAnimation() for single-thread-no-scheduler tests. This would redirect to WebWidgetClient (empty for RenderWidget) in order to pick up test overrides. Instead, ChromeClient goes to WebWidetClient which is RenderWidget (or test overrides). RenderWidget goes to the compositor. Then we don't need the callback from the compositor anymore, so remove it and change tests to watch ScheduleAnimation() as needed directly instead. WebLayerTreeView also has an equivalent of ScheduleAnimation() which would get to the test harness by round-tripping through cc. Instead of re-routing it, remove that API and have callers go through the WebWidgetClient to ScheduleAnimation(). R=dcheng@chromium.org TBR=dcheng for components/ Change-Id: I3c1a5a4c2c6dfc8008067891531b35e5d845b4ba Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1369032 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615656}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .