commit | 545f0d025ef1f93aa276c4da765f5450013014dc | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Fri Feb 08 06:21:13 2019 |
committer | Robbie Iannucci <iannucci@chromium.org> | Fri Feb 08 06:21:13 2019 |
tree | 4352006bdc97066b39fb15862b9293cb3856e53c | |
parent | f2f4cc6382f9d132699de64e656d13e6b798c4fe [diff] |
Manual recipe roll. recipe_engine: https://crrev.com/e5b95408b9e4b89a7b88f67c40b3af79a88a7ad7 [step_runner] Specify close_fds to avoid leaking non-std handles to steps. (iannucci@chromium.org) https://crrev.com/bcd44328140e7912e96e2fd0ae1c76222ebca167 Revert "[step_runner] Specify close_fds to avoid leaking non-std handles to steps." (tandrii@chromium.org) TBR=tandrii@google.com Bug: 930038 Change-Id: Ia8cef1190df752029980812fa3a4e422f3a54dee Reviewed-on: https://chromium-review.googlesource.com/c/1460142 Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.